Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cordova/apple/macos): create new NETunnelProviderManager instances when moving to Catalyst #1822

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Jan 19, 2024

Internally, iOS and macOS use different techniques for identifying code. A macOS-style link in the provider configuration fails to find iOS-style providers. We track whether we need to do this with a version in the providerConfiguration.

@sbruens sbruens requested a review from a team as a code owner January 19, 2024 17:22
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (e8dcd79) 32% compared to head (8e790d3) 32%.

Files Patch % Lines
...ineAppleLib/Sources/OutlineTunnel/OutlineVpn.swift 0% 75 Missing ⚠️
...utlineTunnel/NETunnelProviderManager+Outline.swift 0% 29 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1822   +/-   ##
======================================
- Coverage      32%     32%   -1%     
======================================
  Files          45      46    +1     
  Lines        2609    2670   +61     
  Branches      337     337           
======================================
  Hits          859     859           
- Misses       1750    1811   +61     
Flag Coverage Δ
apple 13% <0%> (-2%) ⬇️
ios ?
maccatalyst 13% <0%> (-2%) ⬇️
macos 13% <0%> (-2%) ⬇️
unittests 32% <0%> (-1%) ⬇️
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if it works for multiple servers!

I'd appreciate it if you could write some tests, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants