Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Kotlin Notebook overview #4112

Merged
merged 9 commits into from May 16, 2024
Merged

Conversation

AlejandraPedroza
Copy link
Contributor

No description provided.

@AlejandraPedroza AlejandraPedroza requested a review from a team as a code owner April 3, 2024 10:41
@AlejandraPedroza AlejandraPedroza force-pushed the kotlin-notebook-overview branch 2 times, most recently from a38fd67 to 47e743b Compare April 29, 2024 14:55
Copy link
Member

@ileasile ileasile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very understandable and straightforward!


![kotlin-notebook-sharing-datalore](kotlin-notebook-sharing-datalore.png){width=700}

## What's next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be a link to the IDEA docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll publish them and then add links to each other (doing this way because they are in different repos).

docs/topics/kotlin-notebook-overview.md Show resolved Hide resolved
Copy link
Collaborator

@cmelchior cmelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 ... only had one small minor comment

docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - very nice job in my opinion! 👍 I left a couple of minor comments.

docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
docs/topics/kotlin-notebook-overview.md Outdated Show resolved Hide resolved
Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you for the changes! LGTM 🚀

@AlejandraPedroza AlejandraPedroza merged commit a252341 into master May 16, 2024
4 checks passed
@AlejandraPedroza AlejandraPedroza deleted the kotlin-notebook-overview branch May 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants