feat: Clarify Dart's closing label by changing it to an End symbol. #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he original closing label in Dart uses a comment which may not be clear, To improve clarity, I propose changing the closing label to an End symbol. This will make it more easily recognizable and reduce confusion in code.
|
Thank you for the pull request. Can you please add the screenshots to the PR description with the suggested change (both light and dark themes)? Is ⦿ a well-known "end symbol"? I'm not sure if all fonts support this symbol nicely. I'm also thinking about a different approach of addressing the confusion. I mean making it look not as a comment but as an inlay hint. Example from Kotlin: As a bonus, inlay hints have context menu that allows disabling them. |
|
Jsut for the reference, here's another example from Kotlin, pretty much the same as Dart closing labels: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original closing label in Dart uses a comment which may not be clear to developers. To improve clarity, I propose changing the closing label to an End symbol. This will make it more easily recognizable and reduce confusion in code.