Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up infrastructure to support different platform versions in single branch #266

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Undin
Copy link
Collaborator

@Undin Undin commented Nov 19, 2023

And support 233 platform as an example

@elmot
Copy link
Member

elmot commented Nov 21, 2023

It seems to me that it's easier to keep version-specific changes in branches, rather than try to keep sources this way.

@Undin
Copy link
Collaborator Author

Undin commented Nov 21, 2023

It seems to me that it's easier to keep version-specific changes in branches, rather than try to keep sources this way.

Of course, it's up to main plugin maintainers, but I have experience with branches in two plugins and in both cases the suggested approach requires much fewer actions because usually there are not so many incompatibilities in the platform

@elmot
Copy link
Member

elmot commented Nov 21, 2023

There is not only platform. but also terminal plugin is used here, and, unfortunately, latter one does not seem very stable.

@Undin
Copy link
Collaborator Author

Undin commented Nov 21, 2023

terminal

It's a bundled plugin, so I think we can bravely consider it as a part of the platform anyway because the update cycle is the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants