Make delay before uploading files configurable #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlasovskikh
suggested changes
Aug 5, 2021
There was a problem hiding this comment.
Thanks for your PR!
I'd actually prefer a different approach easier for the users. It would be cooler to make the delay auto-adjustable based on errors in communicating with the device, so that the user doesn't have to adjust it manually. You can start with 0.5, then on error re-retry with some delay, then do it again a few times.
Where is the microupload.py file? Cant seem to find it |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes MicroPython firmware can send a lot of additional information on startup (e.g.
esp32-idf3-20200902-v1.13.bin). Such behavior breaks microupload.py since the hardcoded half-second is not enough.This PR adds an additional option to the
Settingspane that lets you modify board detection delay.