Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new classes to wikitext created emphasised elements to make them easily stylable #8163

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pmario
Copy link
Contributor

@pmario pmario commented Apr 22, 2024

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Apr 22, 2024 11:42am

@Jermolene
Copy link
Owner

Hi @pmario I am concerned that the CSS selector here may trigger some false positives. The most obvious anomaly would be something like this:

<strong>
This is bold
<div style="font-weight:normal;">
This is not bold
<$link>
This should not be bold
<$/link>
</div>
</strong>

@pmario
Copy link
Contributor Author

pmario commented Apr 22, 2024

I am concerned that the CSS selector here may trigger some false positives

You are right. We need to be more specific. I had a look. We should add a new tc-emphasis tc-strong to the STRONG element created by the wikitext bold-parser.

The same should be true for: italic, strikethrough, subscript, subscript, superscript, underscore and inline-code

@pmario
Copy link
Contributor Author

pmario commented Apr 22, 2024

It seems to work fine now

<strong>
This is bold, 
<div style="font-weight:normal;">

This is not bold

<$link>This should not be bold</$link>

''<$link>This should be bold</$link>''

</div>
</strong>

//[[Internal link italics|example in italics]]// - It's italic also when the tiddler exists

''[[Internal link bold|example in bold]]'' - it's italic too, if tiddler does not exist

@pmario pmario changed the title allow internal link to be wikitex formatted as bold add new classes to wikitext created emphasised elements to make them easily stylable Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] wikitext formatting a link in italic works - bold does not work
2 participants