Configure hostnames individually #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it isn't set, fallback to current host.
This frees DefaultUrlResolver from the global configuration instance. This is necessary when multiple configurations are needed in the same application.
Previously the hostname specified for notification was used in all scenarios. Success and Failed URLs do not need to be publicly accessible so when developing locally these can be set to localhost, or a local hostname.
|
Build on change in #19 |
|
Minor note: string notificationHostName; is left unused - where previously it was used by the property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow hostnames for success and failed to be specified
Previously the hostname specified for notification was used in all
scenarios. Success and Failed URLs do not need to be publicly accessible
so when developing locally these can be set to localhost, or a local
hostname.