Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colored Amoled #1670

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Colored Amoled #1670

wants to merge 2 commits into from

Conversation

e-shl
Copy link

@e-shl e-shl commented Nov 4, 2023 •
edited

Current Amoled mode completely hides the interface elements

@e-shl
Copy link
Author

e-shl commented Nov 4, 2023 •
edited

Or use slightly grayish static color

UPD: I realized that overdone darkest gray, need a lighter

@e-shl e-shl changed the title Amoled use Base primaryVariantTachiyomi for controls elements Amoled use Theme's color primaryVariantTachiyomi for controls elements Nov 5, 2023
@Saud-97
Copy link

Saud-97 commented Nov 5, 2023

Maybe set a color for the borders around the blacked out panels instead of adding background color.

Jays2Kings
Jays2Kings reviewed Nov 6, 2023
View reviewed changes
Copy link
Owner

@Jays2Kings Jays2Kings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not 100% sure on this pr anyway, since i haven't heard from others they want contrast with these panels. people who use amoled use it because they think it provides more battery saving so aesthetics dont really matter here

app/src/main/res/layout/filter_bottom_sheet.xml Outdated Show resolved Hide resolved
@e-shl e-shl changed the title Amoled use Theme's color primaryVariantTachiyomi for controls elements Colored Amoled and Contrast Amoled Nov 7, 2023
@e-shl
Copy link
Author

e-shl commented Nov 8, 2023

im not 100% sure on this pr anyway, since i haven't heard from others they want contrast with these panels. people who use amoled use it because they think it provides more battery saving so aesthetics dont really matter here

Now everyone should be satisfied

e-shl
e-shl commented Nov 9, 2023
View reviewed changes
Copy link
Author

@e-shl e-shl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e-shl
no container but content from reader_chapters_sheet
It looks like I made a mistake in the name of the container *tabbed_bottom_sheet

@e-shl e-shl changed the title Colored Amoled and Contrast Amoled Colored Amoled Nov 10, 2023
@ourslfs
Copy link

ourslfs commented Jan 10, 2024

just leave an option not to do any coloring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jays2Kings Jays2Kings Awaiting requested review from Jays2Kings

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@e-shl @Saud-97 @ourslfs @Jays2Kings