Adds onPaste validation, fix adds with decimal and toPresicion bug #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachodd
commented
May 18, 2021
nachodd
commented
- Adds onPaste handler that check if the actual value pasted is a valid Numeric value.
- Corrects a bug when adding or subtracting numbers with decimals.
- Fix toPresicion fn bug: If the initial value is an integer, it fails to apply toFixed
…icion bug - Adds onPaste handler that check if the actual value pasted is a valid Numeric value. - Corrects a bug when adding or subtracting numbers with decimals. - Fix toPresicion fn bug: If the initial value is an integer, it fails to apply toFixed
|
I've also created another validations, like disabling the "e" to be entered (as input type number supports scientific notation, but is rarely used). If you want, I can create another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.