fix: chown fail when OS create folders or files with root only permission #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FlorianHockmann tagging you as |
FlorianHockmann
approved these changes
May 2, 2024
There was a problem hiding this comment.
I don't know why we had this recursive flag, but it has been like that since the very first version of our Docker images: JanusGraph/janusgraph-docker@1bb998c
But I agree that it shouldn't be needed so I'm OK with removing it.
porunov
approved these changes
May 2, 2024
There was a problem hiding this comment.
Thank you @tien !
I left some thoughts below, but generally it LGTM.
I personally am not using JanusGraph Docker image, so I will rely more on reviews from @FlorianHockmann and @farodin91 here.
…sion Signed-off-by: Tiến Nguyễn Khắc <tien.nguyenkhac@icloud.com>
porunov
approved these changes
May 5, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having issue with Janusgraph whenever the OS create files or folders in the Janusgraph owned directory. For example, when the system restart unexpectedly and a
lost+foundfolder is created. Thelost+foundcreated byfsckhave root only access, sochownwill fail.I don't think
chownneed to be recursive because files that are created & used by Janusgraph will all be created by the default user (janusgraph) anyway.