Add text wrapping to the import dialog #11107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! |
|
can you add a screenshot? |
|
What's wrong with the fetcher tests? |
Siedlerchr
previously approved these changes
Mar 27, 2024
|
Changelog please :) |
Closed
2 tasks
Siedlerchr
previously approved these changes
Mar 27, 2024
calixtus
reviewed
Mar 27, 2024
Comment on lines
14
to
18
| .list-cell:default { | ||
| -fx-padding: 0.5em 0.1em 0.5em 0em; | ||
| } | ||
|
|
||
| .list-cell:entry-selected { | ||
| -fx-background-color: derive(-jr-selected, 35%); | ||
| } | ||
|
|
||
| .list-cell:entry-selected .summary > Text { | ||
| -fx-fill: js-summary-text-color-selected; | ||
| .list-cell:selected { |
There was a problem hiding this comment.
Im not sure, but i think this will also affect the dropdown menu to select the library to import to. Better select the import list by id and then select in the hierarchy below.
There was a problem hiding this comment.
I just removed them, and it looks like it's all good.
Siedlerchr
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Add wrapping at import dialog #10931.
Fixes IndexOutOfBoundsException while selecting web search result entries in a particular order #11081. This was a bug in controlsfx, which was fixed in BitSetReadOnlyUnbackedObservableList should implement indexOf controlsfx/controlsfx#1541. Just updated to version 11.2.1.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)