Issue #17 Make Identifiers-check Case Insensitive

Additional changes: Increased Version Number to 4.0.0 because of breaking changes in the mapping. Released a new Version to Maven.
JSqlServerBulkInsert · Feb 13, 2021 · 02f268c · 02f268c
1 parent b14be98
commit 02f268c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 13 deletions.
diff --git a/JSqlServerBulkInsert/deployment/deploy_release.bat b/JSqlServerBulkInsert/deployment/deploy_release.bat
@@ -8,8 +8,8 @@ echo - Bundling Artifacts for OSSRH Repository Upload  -
 echo ---------------------------------------------------
 
 :: Define the Executables, so we don't have to rely on pathes:
-set MVN_EXECUTABLE="C:\Program Files (x86)\Maven\apache-maven-3.3.9\bin\mvn.cmd"
-set GPG_EXECUTABLE="C:\Program Files (x86)\GNU\GnuPG\pub\gpg.exe"
+set MVN_EXECUTABLE="G:\Applications\apache-maven-3.6.3\bin\mvn.cmd"
+set GPG_EXECUTABLE="C:\Program Files (x86)\gnupg\bin\gpg.exe"
 
 :: GPG Key ID used for signing:
 set GPG_KEY_ID=E4B54CD3

diff --git a/JSqlServerBulkInsert/pom.xml b/JSqlServerBulkInsert/pom.xml
@@ -7,7 +7,7 @@
 
     <groupId>de.bytefish</groupId>
     <artifactId>jsqlserverbulkinsert</artifactId>
-    <version>3.0.0</version>
+    <version>4.0.0</version>
     <name>jsqlserverbulkinsert</name>
     <description>JSqlServerBulkInsert is a Java library for Bulk Inserts to the SQL Server.</description>
     <url>http://www.github.com/bytefish/JSqlServerBulkInsert</url>

diff --git a/JSqlServerBulkInsert/src/main/java/de/bytefish/jsqlserverbulkinsert/util/SchemaUtils.java b/JSqlServerBulkInsert/src/main/java/de/bytefish/jsqlserverbulkinsert/util/SchemaUtils.java
@@ -7,10 +7,7 @@
 import java.sql.Connection;
 import java.sql.DatabaseMetaData;
 import java.sql.ResultSet;
-import java.util.ArrayList;
-import java.util.Comparator;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
 import java.util.stream.Collectors;
 
 public class SchemaUtils {
@@ -56,14 +53,14 @@ public static <TEntity> void validateColumnMapping(Connection connection, Abstra
         // Try to obtain the Schema:
         SchemaMetaData schemaMetaData = internalGetSchemaMetaData(connection, mapping);
 
-        // We cannot validate, perhaps no permissions to read the Information Schema, we shouldn't
-        // stop at all, because this might be valid. Nevertheless it may lead to subtle errors and
+        // We cannot validate, perhaps no permissions to read the Meta Data? We shouldn't throw an
+        // Exception, because this might be valid. Nevertheless it may lead to subtle errors and
         // we should probably log it in the future:
         if(schemaMetaData == null || schemaMetaData.getColumns() == null || schemaMetaData.getColumns().isEmpty()) {
             return;
         }
 
-        // We cannot continue, if not all columns have been populated:
+        // We have read the DatabaseMetaData and cannot continue, if not all columns have been populated:
         if(mapping.getColumns().size() != schemaMetaData.getColumns().size()) {
             throw new RuntimeException("Destination Table has '" + schemaMetaData.getColumns().size() + "' columns, the Source Mapping has '" + mapping.getColumns().size() +"' columns.");
         }
@@ -84,13 +81,13 @@ public static <TEntity> List<IColumnDefinition<TEntity>> getSortedColumnMappings
         // Build a Lookup Table:
         Map<String, IColumnDefinition<TEntity>> columnDefinitionLookup = mapping.getColumns()
                 .stream()
-                .collect(Collectors.toMap(x -> x.getColumnMetaData().getName(), x -> x));
+                .collect(Collectors.toMap(x -> x.getColumnMetaData().getName().toUpperCase(), x -> x));
 
         // Now Sort the Column Definitions:
         List<IColumnDefinition<TEntity>> sortedColumns = new ArrayList<>();
 
         for (SchemaMetaData.ColumnInformation columnMetaData : schemaMetaData.getColumns()) {
-            IColumnDefinition<TEntity> columnDefinition = columnDefinitionLookup.get(columnMetaData.getColumnName());
+            IColumnDefinition<TEntity> columnDefinition = columnDefinitionLookup.get(columnMetaData.getColumnName().toUpperCase());
 
             sortedColumns.add(columnDefinition);
         }

diff --git a/README.md b/README.md
@@ -14,7 +14,7 @@ You can obtain [JSqlServerBulkInsert] from Maven by adding the following:
 <dependency>
 	<groupId>de.bytefish</groupId>
 	<artifactId>jsqlserverbulkinsert</artifactId>
-	<version>3.0.0</version>
+	<version>4.0.0</version>
 </dependency>
 ```