Skip to content

JRyanHenson/my-pwp-ryan

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

31 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

my-pwp-ryan

Milestone 1

Feedback

Great job on Milestone 1. Your directory structure is perfect. You have a few small errors in the HTML and .gitignore which I will go over later. The persona, audience, and goal are also perfect and they lay the groundwork for the persona and use case. The persona lays out exactly what type of users will be using your site, and the use case lays out how the users will be interacting with the site.

Edits/Suggestions

In the .gitignore you misspelled /vendor that needs to be corrected right away. You are also using the <center> tag which has been deprecated in favor of CSS https://developer.mozilla.org/en-US/docs/Web/HTML/Element/center. I would also be careful with the technology you lay out for the persona. By stating that your ideal user will be using Windows XP you would have to make your site is cross compatible with browsers that XP can run (Internet Explorer 6 yuck).

Milestone 2a feedback

Your directory structure continues to look great, and your code has passed inspection by W3 Validator, great job!

You've described your layout very clearly, and it matches your wireframes exactly. You've done a great job breaking up the flow of the page as well. However, I'm a little concerned that your PWP may be too text heavy, and lacking images or other media to break up the text. Have you given any thought to adding some type of media, or maybe some visually pleasing CSS to your PWP? I think it would go a long way towards enhancing your end user's experience. It doesn't have to be anything huge, but maybe showcasing some aspects of your projects, or previous work. Possibly adding some personal pictures, or landscapes? It's a personal choice, but I highly recommend adding some media to your layout.

You've passed milestone 2a with a tier IV! You're free to begin work on milestone 2b. However, I would like you to consider my comments above, and if you're on board to add media to your layout, please submit new wireframes with the media included. If you have any questions please let me know.

Milestone III

Feedback

Awesome job on your PWP. The white and grey layout is really clean and profesional looking. The particle animation is a nice flair that does not take away from the rest of the page. I also like the placement of your photo and how well it scales. The about me section does a great job of highlighting yourr skills in both web development and security. As you get more projects under your belt I recommend that you think about ways to make your portfolio section more dynamic, so that you are not constantly manipulating the html in that section. I tested your email form and it successfully sent an email. I hope that PWP was a good learning experince and I am excited to see what you accomplish after graduation.

Final Grade

** Final Grade 38/40 95%

  • Milestone 1 - 20%: Tier III 30(0.2) = 6
  • Milestone 2a - 20%: Tier IV 40(0.2) = 8
  • Milestone 2b - 10%: Tier IV 40(0.1) = 4
  • Milestone 3 - 50%: Tier IV 40(0.5) = 20

About

No description, website, or topics provided.

Resources

License

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published