Income and expenses in alphabetic order #3192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILIYANGERMANOV
requested changes
May 12, 2024
| @@ -598,7 +598,7 @@ class EditTransactionViewModel @Inject constructor( | |||
| private fun createCategory(data: CreateCategoryData) { | |||
| viewModelScope.launch { | |||
| categoryCreator.createCategory(data) { | |||
| categories.value = categoryRepository.findAll().toImmutableList() | |||
| categories.value = categoryRepository.findAll().sortedBy { it.name.value }.toImmutableList() | |||
There was a problem hiding this comment.
This shouldn't be the default behavior. Most users prefer to see the categories in the order that they've put them in the Categories screen. Make this feature a Setting using Features and IvyFeatures and by default it must be off
| @@ -632,7 +632,7 @@ class EditTransactionViewModel @Inject constructor( | |||
| private fun editCategory(updatedCategory: Category) { | |||
| viewModelScope.launch { | |||
| categoryCreator.editCategory(updatedCategory) { | |||
| categories.value = categoryRepository.findAll().toImmutableList() | |||
| categories.value = categoryRepository.findAll().sortedBy { it.name.value }.toImmutableList() | |||
There was a problem hiding this comment.
This code is duplicated 3 times, extract it as a function
ILIYANGERMANOV
added
the
requested changes
|
I'm going to close this PR because I sent other with the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
mainbranch.