Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bulid*.yml #2238

Open
wants to merge 4 commits into
base: 1.18.2
Choose a base branch
from
Open

Update bulid*.yml #2238

wants to merge 4 commits into from

Conversation

LY-Xiang
Copy link

@LY-Xiang LY-Xiang commented Feb 6, 2024

actions/* v2->v4
Kir-Antipov/mc-publish v3.2->v3.3

@IMS212
Copy link
Member

IMS212 commented Feb 6, 2024

Um... this doesn't actually build.

add distribution: 'temurin'
@LY-Xiang
Copy link
Author

LY-Xiang commented Feb 6, 2024

setup-java@v4

  • distribution: 'temurin'

Copy link

@Kichura Kichura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkout step has no "name" statement, meaning it has no friendly name.

+13L - name: Checkout sources
@LY-Xiang
Copy link
Author

LY-Xiang commented Feb 9, 2024

L13

  • name: Checkout sources

Copy link

@Kichura Kichura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite check-latest: true being excluded below java-version: 17 for auto-updating reasons - lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants