Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZUGFeRD 2.2 #1048

Draft
wants to merge 67 commits into
base: development
Choose a base branch
from
Draft

ZUGFeRD 2.2 #1048

wants to merge 67 commits into from

Conversation

gklimm
Copy link
Collaborator

@gklimm gklimm commented May 2, 2024

Description

Implementation of the current Version of ZUGFeRD 2.2

Related Issue

#913 & #999

Motivation and Context

Digital invoices will be legally binding in Germany from 2025 in B2B

Screenshots (if appropriate):

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

naui95 and others added 30 commits December 16, 2023 18:11
In version 1.6.0 the logo isn't shown on the PDF invoice. When changing line 39 the logo returns.
When selecting an email template, it won't get inserted into the textarea. val() instead of html() has to be used here.
I got this error when viewing an unpaid invoice:

Severity: Warning
Message: Undefined variable $payment_cf_exist
Filename: views/view.php
Line Number: 247

Solution was quite simple.
Make $item->product values available in quotes (just as they are in invoices)
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
nielsdrost7 and others added 28 commits December 16, 2023 18:11
…e was a possible vulnerability for those field
…ity for that field. Clean up some spacing issues
- Properly check for the $token from the request, to see if they only have alpha_numeric values.
- Properly check email address if it's a valid email address
There were security vulnerabilities where this wasn't checked properly.
* #2023-23011: clean xss input for a posted quote_id and client_id variable

* #2023-23011: clean xss input for a get filter_product and filter_family variable, it's then outputted to the screen

* #2023-23011: clean xss input for posted invoice_id

* #2023-23011: clean xss input for posted invoice_id, invoice_terms, invoice_password (!) and payment_method
…rtant. Changed a setting in /application/config.php to env_bool instead of _env
* #973: Bug fixes after a report in the comments of PR #973: too many xss_clean functions

* #973: Applied xss_clean on too many places. This is the correction

* #973: Quick commit
This reverts commit 197b148.
@nielsdrost7 nielsdrost7 marked this pull request as draft May 2, 2024 22:35
@InvoicePlane InvoicePlane deleted a comment from johnfoley May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants