Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credit Note/Invoice #1026

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from
Draft

Credit Note/Invoice #1026

wants to merge 5 commits into from

Conversation

Verony-makesIT
Copy link
Contributor

Description

Related Issue

  1. [Feature Request] Credit invoice with different template #763
  2. Credit invoice date not correct
  3. Credit invoice template feature developed

Motivation and Context

This PR resolves the issue (Related Issue 2.).
Also creates an additional Invoice group item for the purpose of credit notes.
When creating a credit note, it will:

  • change all invoice entries to credit note entries including credit note terms in the invoice form and templates. (Related Issue 1.)
  • change the creation date to today's date. (Related Issue 2.)
  • check whether the 'Default Credit Note/Invoice Group' in Settings has already been filled in.

Screenshots (if appropriate):

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • New Feature

@Verony-makesIT
Credit note/Invoice function added
2301f16 
Create credit note invoices:
- Credit note number
- Credit note/invoice setting = Default  CN group
- Change CN to todays date and due date = disabled
@Verony-makesIT
Added CN settings IP PDF template
a69ef45
@Verony-makesIT
Small update in InvoicePlane.php template
ec44d8c
@Verony-makesIT
Added CN functionality + minor updates
d6b645a 
- insert Credit note default item into ip_invoice_groups db
- added Settings Credit terms
- verify if  Default credit note  is filled in create credit modal
- changed 'invoice terms' to 'credit terms' in Credit Invoice page
- added 'credit invoice' to pdf- and public template
- fixed a bug in modal create credit (client name did not show)
@Verony-makesIT Verony-makesIT self-assigned this Jan 30, 2024
@Verony-makesIT
Copy link
Contributor Author

Here you can find some more relevant screenshots.

Credit Invoice page:
image

Settings - Invoice Group Form & Invoices Group and Terms
image

Modal (Credit) Invoice Group: not selected!
image

InvoicePlane PDF
image

InvoicePlane_Web:
image

@Verony-makesIT Verony-makesIT marked this pull request as ready for review January 30, 2024 18:40
@aksysict
Copy link

aksysict commented Jan 31, 2024 •
edited

Using qr code and the invoice_sign is -1 it gives an error, there needs to be a check before loading qr code on invoice pdf

@Verony-makesIT
Copy link
Contributor Author

@aksysict,
thanks for reporting this.
I will look into this ASAP.

@aksysict
Copy link

aksysict commented Feb 1, 2024

@aksysict, thanks for reporting this. I will look into this ASAP.

with the code you added for the qr code, you get a empty pdf only with logo en company and client details no details about the items and prices

@Verony-makesIT
Copy link
Contributor Author

@aksysict,
I added a check only for the QR-Code (if invoice_sign != -1) to the pdf template.
Then I created a new invoice and subsequently created a credit invoice from it (without any problems!).
See this screenshot of the invoice and of the credit invoice pdf (including items and prices).
image

So this should no longer cause a problem.

@nielsdrost7 nielsdrost7 marked this pull request as draft February 2, 2024 03:13
@aksysict
Copy link

aksysict commented Feb 6, 2024

@aksysict, I added a check only for the QR-Code (if invoice_sign != -1) to the pdf template. Then I created a new invoice and subsequently created a credit invoice from it (without any problems!). See this screenshot of the invoice and of the credit invoice pdf (including items and prices). image

So this should no longer cause a problem.

you are right it was the file that was corrupted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Verony-makesIT Verony-makesIT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Verony-makesIT @aksysict