Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service for a company #1020

Open
wants to merge 73 commits into
base: development
Choose a base branch
from

Conversation

ThierryHFR
Copy link

Description

I've been using InvoicePlane for a number of years.
I have several customers who have departments, and these customers ask us to send invoices directly to the relevant department.
So I've added service management for customers.
I finally took the time to clean it up and offer it as a feature.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Add 2 entries to add and list services

menu-service

Service creation page

create-service

Service selection when creating a quote or invoice

create-quotr

When listing quotes or invoices, the service appears in brackets.

lisste-facture

On quotations or invoices, the service appears under the customer's name.

devis-facture

Pull Request Checklist

  • My code follows the code formatting guidelines.
  • I have an issue ID for this pull request.
  • I selected the corresponding branch.
  • I have rebased my changes on top of the corresponding branch.

Issue Type (Please check one or more)

  • Bugfix
  • Improvement of an existing Feature
  • [X ] New Feature

naui95 and others added 30 commits December 16, 2023 18:11
In version 1.6.0 the logo isn't shown on the PDF invoice. When changing line 39 the logo returns.
When selecting an email template, it won't get inserted into the textarea. val() instead of html() has to be used here.
I got this error when viewing an unpaid invoice:

Severity: Warning
Message: Undefined variable $payment_cf_exist
Filename: views/view.php
Line Number: 247

Solution was quite simple.
Make $item->product values available in quotes (just as they are in invoices)
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

application/modules/quotes/views/view.php Outdated Show resolved Hide resolved
application/modules/invoices/views/view.php Outdated Show resolved Hide resolved
application/modules/services/views/form.php Outdated Show resolved Hide resolved
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

application/modules/quotes/views/view.php Show resolved Hide resolved
application/modules/invoices/views/view.php Show resolved Hide resolved
@nielsdrost7 nielsdrost7 added the Feature Request Improvement or Feature Request label Jan 27, 2024
@nielsdrost7
Copy link
Contributor

Great job, man!
May I ask: can you turn those fields off with a setting? I might have overlooked it when I looked at your pull-request

@ThierryHFR
Copy link
Author

Great job, man!
May I ask: can you turn those fields off with a setting? I might have overlooked it when I looked at your pull-request

No, they cannot be disabled. I'm working on the assumption that the service is not systematic and can therefore be null. The behavior remains the same as at present.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@ThierryHFR ThierryHFR changed the title WIP: Add service for a company Add service for a company Jan 28, 2024
@ThierryHFR
Copy link
Author

Hi @nielsdrost7 ,
I've put all the database modifications in a single 038_1.6.x.sql file.
Do I need to make one file per modification?

@nielsdrost7
Copy link
Contributor

nielsdrost7 commented Jan 29, 2024

Do I need to make one file per modification

1 file is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Improvement or Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants