Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appearance - show keyboard hints #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iksi4prs
Copy link
Contributor

@iksi4prs iksi4prs commented Jan 4, 2024

Motivation
Improve usability by showing user keyboard shortcuts on screen

Scope
Added new tab called "Appearance" under settings.
(Name and icon were selected to be same as in Google chrome).
The new tab has a checkbox to control whether keyboard hints should be visible in top bar.
For backwards compatibility, the checkbox controls visibility of hints only on top bar, not on bottom (eg F4, F5, etc)
See attached image.
(Future feature in settings is to move also "Theme" from "General" to "Appearance", same as in Google Chrome)

image

@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (3330b67) 92.89% compared to head (d02b53c) 92.50%.

Files Patch % Lines
...mentations/Settings/AppearanceSettingsViewModel.cs 25.00% 12 Missing ⚠️
src/Camelot.Services/AppearanceSettingsService.cs 55.00% 8 Missing and 1 partial ⚠️
...ns/MainWindow/Operations/TopOperationsViewModel.cs 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   92.89%   92.50%   -0.39%     
==========================================
  Files         185      187       +2     
  Lines        4830     4873      +43     
  Branches      388      392       +4     
==========================================
+ Hits         4487     4508      +21     
- Misses        288      309      +21     
- Partials       55       56       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants