removed IIC bus initialization in begin function #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
While trying out a setup with two different TLE493D-p2b6 sensors (A2 and A3) connected to the same IIC bus of an Arduino Teensy 4.0, I encountered malfunctions in communications between the microcontroller and the sensors.
I believe that it is both a logical and a functional mistake to initialize the IIC bus interface (calling
mInterface.bus->begin()) inside thevoid Tle493d::begin(TwoWire &bus, TypeAddress_e slaveAddress, bool reset, uint8_t oneByteRead)method as this functionality should not be handled by the sensor instance. Also, this might cause problems with the IIC interface if multiple sensors are connected to the same bus, as a bus (re)initialization can be performed while it is used by another sensor causing malfunction in the interface.By removing the bus initialization from the library method and performing it only once in the setup of the microcontroller, everything works fine.
Another solution could be to check wether the bus was already initialized with the
isEnabled()method but, as I wrote, I think this kind of functionality shouldn't be handled by the library.