Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pip install (with docs) #280

Merged
merged 45 commits into from
Feb 26, 2024
Merged

Added pip install (with docs) #280

merged 45 commits into from
Feb 26, 2024

Conversation

ben-l-p
Copy link
Collaborator

@ben-l-p ben-l-p commented Feb 8, 2024 •
edited

Extension of Alvaro's pull request HERE, with added documentation and changes to the Github workflows. The Docker build still uses Conda/Mamba - ideally I want to remove this dependency.

Also fixed SciPy issues, as it was using a depreciated FFT function

ACea15 and others added 30 commits May 31, 2023 14:26
@ACea15
add pyproject.toml to download packages prior to build
c5786dc
@ACea15
minimal env (only for people without low level libraries in system)
fb40764
@ACea15
less restricted cmake in the setup (>= added)
70b8b18
@ACea15
add functions to setup to build submodules
330ef4e
@ACea15
add required packages to pip install
216bd5b
@ACea15
remove unnecessary environments (leaving newer for reference)
a9c3194
@ACea15
add option, via environment variable, to not build submodules
85a4475
@ACea15
fix to env for Ubuntu
d0ee119
@ACea15
fix wrong location of variable this_directory in merging conflicts
780714b
@ACea15
simple compilation from run() method
a8d5884
@ACea15
minor environment compatibility for macos
1b0f8af
@ben-l-p
Merge pull request ImperialCollegeLondon#266 from ImperialCollegeLond…
4b5a520 
…on/fix_linear_goland_flutter.ipynb

Changed Github runner from Conda to Mamba
@ben-l-p
Merge branch 'develop' into dev_pip2
4937efe
@ben-l-p
Added documentation for pip install
6529a26 
Also fixed an issue with SHARPy not running due to a package import error.
@ben-l-p
Remove conda/mambda from Github workflow
f390ea0
@ben-l-p
Update dockerfile to remove mamba/conda dependency
4514dea
@ben-l-p
Added CMake install to Dockerfile
52a282e
@ben-l-p
Update Dockerfile
fccaf87
@ben-l-p
Update Dockerfile
de8c9ec
@ben-l-p
Update Dockerfile
4b853cf
@ben-l-p
Update Dockerfile
fa2814a
@ben-l-p
Update Dockerfile
75e3060
@ben-l-p
Update Dockerfile
64e1e68
@ben-l-p
Update Dockerfile
c986f46
@ben-l-p
Update Dockerfile
b32b3a4
@ben-l-p
Update Dockerfile
c1bbc79
@ben-l-p
Update Dockerfile
00ceec2
@ben-l-p
Update Dockerfile
3f922bc
@ben-l-p
Update Dockerfile
47cd979
@ben-l-p
Update Dockerfile
da725ce
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (ee7206f) to head (906a566).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   67.69%   67.69%           
=======================================
  Files         166      166           
  Lines       26709    26709           
=======================================
  Hits        18081    18081           
  Misses       8628     8628

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ben-l-p
Copy link
Collaborator Author

ben-l-p commented Feb 11, 2024

Hold off on approving - some packages for a install have been forgotten

@ben-l-p
Use latest mayavi from Github
e33d2cc 
No longer using "pip install mayavi" as this had build errors depending on python version (known bug)
@ben-l-p
Changed docs to include auto built, added ARM64 Conda environment
6540174
@ben-l-p
Copy link
Collaborator Author

ben-l-p commented Feb 20, 2024

Changes have been made to the Mayavi install (required for TVTK) as there is a bug which can causes installation to fail with pip. It now git clones the latest version for installation - this has been tested on Python 3.10/3.11 on both Ubuntu and Mac.

Also added a second Conda environment for Apple Silicon, as Conda is yet to fully include GCC/GFortran for this. This is purely removing these packages so that it will still "work", you just need to install them yourself instead.

Should all be working now - please test!

rafapalacios
rafapalacios approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@rafapalacios rafapalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working now. Very useful contribution. Thanks!

@ben-l-p ben-l-p merged commit da05729 into ImperialCollegeLondon:main Feb 26, 2024
3 checks passed
This was referenced Feb 26, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafapalacios rafapalacios rafapalacios approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ben-l-p @codecov-commenter @rafapalacios @ACea15