Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend testing to include zenodo and entry points #57

Open
davidorme opened this issue May 2, 2023 · 3 comments
Open

Extend testing to include zenodo and entry points #57

davidorme opened this issue May 2, 2023 · 3 comments

Comments

@davidorme
Copy link
Collaborator

davidorme commented May 2, 2023

Not for release/3.0.0 but we should add tests for the behaviour of the zenodo and entry_point modules. Both of those are communicating with external resources - it isn't immediately clear to me what the way to mock that meaningfully in tests is.

See for example #56

@jacobcook1995
Copy link
Collaborator

taxondb.py also completely lacks unit tests, which I think stems from the same issue (tricky mocking)

@davidorme
Copy link
Collaborator Author

@davidorme
Copy link
Collaborator Author

@jacobcook1995 I've created a branch and pushed a prototype fixture and test to it. I think we can adopt this after PR #115 to mock the communications with the GBIF and NCBI - although NCBI uses FTP now that I think about it. Damn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants