Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation passes with no worksheets #144

Merged
merged 7 commits into from
May 21, 2024

Conversation

davidorme
Copy link
Collaborator

This fixes #143:

The original logic was hopelessly confused about the order in which it tackled problems. It now follows a much clearer system:

  • Clears out incorrect naming of 'standard' sheets.
  • Looks for undocumented data worksheets.
  • Checks each provided data worksheet to make sure it is present and that any linked external file is valid.

I've also tacked on the removal of pytest-flake8: running flake8 during pytest needlessly duplicates the pre-commit hook and the pytest-flake8 package relies on a seriously outdated version of flake8 (4.0.1 versus current 7.0.0). Our pre-commit hook has been auto-updated to 7.0.0 so retaining this in pytest is both pointless and divergent.

@davidorme davidorme linked an issue May 16, 2024 that may be closed by this pull request
Copy link
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments but otherwise looks good to me

setup.cfg Outdated Show resolved Hide resolved
test/test_summary.py Outdated Show resolved Hide resolved
@davidorme davidorme merged commit dfea1af into develop May 21, 2024
17 checks passed
@davidorme davidorme deleted the 143-validation-passes-with-no-worksheets branch May 21, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation passes with no worksheets being described
2 participants