Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation passes with no worksheets being described #143

Closed
jacobcook1995 opened this issue May 16, 2024 · 1 comment · Fixed by #144
Closed

Validation passes with no worksheets being described #143

jacobcook1995 opened this issue May 16, 2024 · 1 comment · Fixed by #144

Comments

@jacobcook1995
Copy link
Collaborator

If a datafile contains worksheets which aren't described then dataset validation should fail. At the moment it fails if at least one data worksheet is described and others are not. In the case where no worksheet is described at all then it passes, which it absolutely shouldn't. This is an important bug to track down
@jacobcook1995 jacobcook1995 changed the title Validation passes if with no worksheets being described Validation passes with no worksheets being described May 16, 2024
@davidorme
Copy link
Collaborator

The logic in _load_data_worksheets is totally borked.

@davidorme davidorme mentioned this issue May 16, 2024
Merged
@davidorme davidorme linked a pull request May 16, 2024 that will close this issue
Validation passes with no worksheets #144
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validation passes with no worksheets ImperialCollegeLondon/safedata_validator
2 participants
@davidorme @jacobcook1995