Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempting to make PModelConst inherit CoreConst #201

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Attempting to make PModelConst inherit CoreConst #201

wants to merge 1 commit into from

Conversation

tztsai
Copy link
Collaborator

@tztsai tztsai commented Mar 26, 2024

Make PModelConst inherit CoreConst, and merge the usage of pmodel_const and core_const in PModelEnvironment.

Description

Attempting to make PModelConst inherit CoreConst and merge their usages.

Fixes #161

Type of change

  • New feature (non-breaking change which adds functionality)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@tztsai tztsai linked an issue Mar 26, 2024 that may be closed by this pull request
Let PModelConst inherit CoreConst #161
Open
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.85%. Comparing base (8f7d032) to head (fa3fe33).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #201      +/-   ##
===========================================
- Coverage    94.86%   94.85%   -0.01%     
===========================================
  Files           28       28              
  Lines         1499     1497       -2     
===========================================
- Hits          1422     1420       -2     
  Misses          77       77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tztsai tztsai self-assigned this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tztsai tztsai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let PModelConst inherit CoreConst
2 participants
@tztsai @codecov-commenter