Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let PModelConst inherit CoreConst #161

Open
tztsai opened this issue Jan 9, 2024 · 0 comments · May be fixed by #201
Open

Let PModelConst inherit CoreConst #161

tztsai opened this issue Jan 9, 2024 · 0 comments · May be fixed by #201
Labels
enhancement New feature or request

Comments

@tztsai
Copy link
Collaborator

tztsai commented Jan 9, 2024 •
edited

In PR #139, in many places a single object const is replaced by two objects core_const and pmodel_const, and the developer also has to keep in mind which class (CoreConst or PModelConst) a particular constant belongs to when implementing functions. If PModelConst can inherit CoreConst, the code may be more concise (as only a single ConstantsClass object is needed in each function or method).
@tztsai tztsai added the enhancement New feature or request label Mar 26, 2024
@tztsai tztsai self-assigned this Mar 26, 2024
@tztsai tztsai linked a pull request Mar 26, 2024 that will close this issue
Attempting to make PModelConst inherit CoreConst #201
Draft
5 tasks
@tztsai tztsai linked a pull request Mar 26, 2024 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
ICCS development board
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempting to make PModelConst inherit CoreConst ImperialCollegeLondon/pyrealm
1 participant
@tztsai