Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line hook and logging for splash. #127

Open
davidorme opened this issue Oct 13, 2023 · 0 comments
Open

Command line hook and logging for splash. #127

davidorme opened this issue Oct 13, 2023 · 0 comments
Assignees

Comments

@davidorme
Copy link
Collaborator

splash_v1 was written as a command line application and providing a entry point through pyrealm to allow it to be used in that way again would be good.

As part of that, we'd likely want some kind of logging process to report on activity and the feature/splash_v1 branch includes a logger.py module that was used to do this in the previous implementation. Something needs to be done with that logger.py functionality. We could just strip it all out (and still have an entry point) but it seems more sensible to integrate it and retain the logging.

At the moment, pyrealm doesn't emit logging messages for anything. That's based on the idea that it is primarily used interactively via notebooks and scripts rather than running command line applications, but I think that is likely to change. I'm not sure whether we initially just roll out logging for SPLASH and then think about what other entry points we might want to add and which might then need some logging messages added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant