Fix incorrect widget LEFT state #559
Open
+54
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzn
approved these changes
May 30, 2023
xzn
reviewed
May 30, 2023
|
Thanks for pushing this forwards! Could you indicate how we can test this out? Would love to get it in, but I'm not sure how to properly test it. |
RobLoach
requested changes
Apr 10, 2024
| @@ -34,8 +34,7 @@ nk_widget_text(struct nk_command_buffer *o, struct nk_rect b, | |||
| label.w = NK_MAX(1, 2 * t->padding.x + (float)text_width); | |||
| label.x = (b.x + t->padding.x + ((b.w - 2 * t->padding.x) - label.w) / 2); | |||
| label.x = NK_MAX(b.x + t->padding.x, label.x); | |||
| label.w = NK_MIN(b.x + b.w, label.x + label.w); | |||
| if (label.w >= label.x) label.w -= label.x; | |||
| label.w = NK_MIN(b.w, label.w); | |||
There was a problem hiding this comment.
This change looks unrelated?
There was a problem hiding this comment.
Suggested change
| label.w = NK_MIN(b.w, label.w); | |
| label.w = NK_MIN(b.x + b.w, label.x + label.w); | |
| if (label.w >= label.x) label.w -= label.x; |
There was a problem hiding this comment.
x+w is the coordinate, w is the distance, and the physical meaning of associating these two quantities seems incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.