Fix that graphs disappear after using form controls #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
added
bug
Currently, form first and detach second. Any other last. (e.g. grafana's iframe)
This is a potential breaking change for behaviors which rely on being able to change content in-place even if the response's content is not applied. This is the case for grafana's iframe behavior, though that's more a hack than a necessity so it doesn't break. I've found no other implementations so I guess it's fine including it here.
Don't reject autorefreshes if an autosubmit element is focused but not interacted with fixes #4996
nilmerg
force-pushed
the
fix/disappearing-graphs-4996
branch
from
ac60fdb
to
d994f68
Compare
sukhwinder33445
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.