Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js: Also preserve scroll-y upon auto-refresh #5015

Merged
merged 1 commit into from May 19, 2023
Merged

Conversation

lippserd
Copy link
Member

@lippserd lippserd commented Mar 23, 2023

Although Icinga Web itself doesn't allow scrolling along the y-axis, there may be modules that do. So far we've only kept scrolling position on the x-axis. Now we also support preserving the scrolling position along the y-axis. requestAnimationFrame() is used in order to prevent flickering.

@lippserd lippserd added the bug Something isn't working label Mar 23, 2023
@cla-bot cla-bot bot added the cla/signed label Mar 23, 2023
@lippserd lippserd requested a review from nilmerg March 23, 2023 08:36
@nilmerg nilmerg added area/javascript Affects the javascript framework and removed bug Something isn't working labels May 19, 2023
@nilmerg nilmerg merged commit a323555 into master May 19, 2023
10 checks passed
@nilmerg nilmerg deleted the also-preserve-scroll-y branch May 19, 2023 13:29
@nilmerg nilmerg added this to the 2.12.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript Affects the javascript framework cla/signed
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants