New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphs disappear after form controls are used after icingaweb2 2.11.3 #4996
Comments
Hi, I can't reproduce this. For me, graphs update according to my choice. Be it in a list or the detail view of an object.
The default is "1 Hour". Is this is an error or is this really your default?
There were several JS changes in recent updates of this module. Have you made sure to not get outdated/cached JS anytime you switched a version? Perform a hard-reload to ensure this (Ctrl+R, Ctrl+F5, ...) after a version change and report back please. |
Hello. The defaults we use are 1 day, but setting it to 1 hour still occurs. I've recorded a video of it happening, since I might not have explained well how to trigger it, with the following module configuration (in this case it should be the same as the default, but please confirm): Here's the video: Notice that at first, all is OK. Then I select a different range, wait about 10 seconds, graph image disappears. Then select some more ranges, graph reappears only to disappear after 10 seconds. At some point (mouse disappears), is when I go trigger a refresh (ended up pressing F5...), graph reappears and image stays (refreshes correctly). Then change the range again, trigger the issue after more 10 seconds. Can't be a cache issue, since we have this happen in multiple installations, including a freshly installed one that never had other icinga versions, happens in multiple client machines, both in firefox and chrome (didn't test other browsers, but not relevant I think). Also, reverting to icingaweb2 2.11.2 (via yum downgrade) the issue consistently stops occurring, As for the servers, should it be relevant (I thought it wouldn't be but...) I can give some examples where I consistently reproduced this:
|
Aye, wasn't aware anymore that this is configurable.
Thanks. Though, I did exactly the same and hadn't an issue. Because of that I can't help you directly, I'm afraid. Try to pin down the issue yourself, a few hints:
|
Good morning. Nothing appears on the javascript console, there are no errors on network tab either. Maybe there's some icingaweb2 debug setting I could enable on my side that could help? (I see a I'm sending my user settings in the following image, maybe is relevant since this won't happen if you have auto-refresh disabled (and as far as I know, it's enabled by default) or the refresh speed isn't the default - this is important for the issue to happen in about 10 (to 15?) seconds: Other way I've been able to reproduce: you don't even need to change the value on the form, it's enough to click on a select box and leave it that way until the page auto-refreshes for the graph to disappear: as long as one of the elements of the form has the focus, the issue is triggered. Maybe when you're trying, for some reason there is some other element on your browser that takes away the focus (maybe some other extension you have?), because here - tested in firefox and chrome (linux, windows) and edge (windows) - the select box of the form always keeps the focus, and that 100% triggers the issue in every of our instances for us, which I'd say it makes sense if you look at the code I mentioned above at:
Note: we didn't test this in master version of icingaweb2, do you think that could be relevant we try that instead? It always happens with the official packages for 2.11.3 and 2.11.4, and not for 2.11.2 and below... |
Reproduced it now. I have another module active that interferes in a way that prevents this issue. Though, it definitely needs a fix in Icinga Web. |
Hello together |
@nilmerg Do I understand correctly that the issue will be resolved in the upcoming version of Icinga Web? |
Maybe. It's not planned yet. |
Having the same issues here, pretty annoying, a fix would be fantastic! :) |
Just add in ../TimeRangePicker/CommonForm.php -> function createSelect() -> This will only reload the div and the Graph will no longer disappear. |
Thanks, dunno if it's correct but atleast it fixes it here, clean patch:
Open for a year already, can paying customer plead for official fix? |
Don't reject autorefreshes if an autosubmit element is focused but not interacted with fixes #4996
Don't reject autorefreshes if an autosubmit element is focused but not interacted with fixes #4996
Actually the same as in my post ;o) |
Expected Behavior
Graphs should never disappear
Current Behavior
Graphs disappear after form controls are used and an autosubmit is made
Possible Solution
Happens since icingaweb 2.11.3 (and still happens in latest release 2.11.4), more specifically since the following change was made in icingaweb2:
8cd8923
Reverting that change in icingaweb2 fixes this issue in graphite module, even in icingaweb2 2.11.4. So I'm not sure if this is something to be tackled as an issue on this module or in icingaweb2, but before submitting there it seemed more appropriate to submit here first (could be something the module is not doing correctly and just worked by luck before the change was made in icingaweb2?)
Steps to Reproduce (for bugs)
After the graphs load for the first time, select "2 Weeks" instead of the default "1 day" (any change triggers the bug, until one forces a refresh of the page manually) and wait about 10 seconds, watch the graph image(s) disappear
Context
No particular context, just normal usage watching graph values history. If you want me to submit this as a icingaweb2 issue please tell me.
Your Environment
icinga2 --version
): not relevantThe text was updated successfully, but these errors were encountered: