Add extension required by Icinga Notifications #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I just needed this today: Happy Birthday little #578 🍰 |
This allows the user to provide the constraint name dynamically, e.g for tables that doesn't have a PK but a `UNIQUE KEY` constraint.
|
I just took over this PR as I needed a change in Icinga DB (or the future Go library) for Icinga/icinga-notifications#61. Next to rebasing this branch, I added one commit introducing a more precise time type, representing nanoseconds. |
oxzi
changed the title
But |
|
|
After talking with @julianbrost about Icinga/icinga-notifications#61, it turns out that I haven't needed a nanoseconds type. Hooray! This PR and its branch now contains @yhabteab's change, just rebased against the current main branch. |
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
Apr 30, 2024
The changed icingadb dependencies contains the latest state of the noma branch[0] with an additional fix for utils.FromUnixMilli[1,2]. [0]: Icinga/icingadb#578 [1]: Icinga/icingadb#753 [2]: Icinga/icingadb@066abea
oxzi
added a commit
to Icinga/icinga-notifications
that referenced
this pull request
May 27, 2024
The changed icingadb dependencies contains the latest state of the noma branch[0] with an additional fix for utils.FromUnixMilli[1,2]. [0]: Icinga/icingadb#578 [1]: Icinga/icingadb#753 [2]: Icinga/icingadb@066abea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to provide the constraint name dynamically, e.g for tables that doesn't have a PK but a
UNIQUE KEYconstraint.