Schedule redesign #183
Draft
Schedule redesign #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
added
enhancement
nilmerg
force-pushed
the
schedule-redesign
branch
3 times, most recently
from
892ad22
to
a64abe5
Compare
nilmerg
force-pushed
the
schedule-redesign
branch
10 times, most recently
from
8bbee2c
to
e760e2c
Compare
nilmerg
force-pushed
the
schedule-redesign
branch
from
2fa84ef
to
99b7187
Compare
nilmerg
force-pushed
the
schedule-redesign
branch
7 times, most recently
from
6e889b4
to
0701662
Compare
If a grid defines a lower maximum row span than what space is available, there is no need to fill all available space.
This is the basis for dynamic grids that are defined by the server to be only as large as required.
…ee name This allows us to finally get rid of the color setting of users and usergroups.
Extra entries shouldn't be dependent on the type of grid. Their placement relies of course on it, but not their existence. So with the new type for grid steps, it's now native to the base implementation and concrete grids only need to describe their steps in more detail.
Allows me to use a less calendar like widget for the timeline.
I'd like to move the calendar and grid implementation to ipl-web some day, and this is one obstacle less.
The class name is probably not final yet, neither is the path.
Allows to add a simpler implementation for fixed layouts.
Which allows an entry provider to use specific rows for its entries.
nilmerg
force-pushed
the
schedule-redesign
branch
from
0b05835
to
3f5da78
Compare
This generalizes the CSS somewhat so that it applies to the new timeline without too much boilerplate.
Think of splitting this up...
grid-gap seems to negate the effect of minmax used to prevent a grid blowout. It's also wrong to apply it on the overlay anyway..
nilmerg
force-pushed
the
schedule-redesign
branch
from
3f5da78
to
95e04cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #177
requires Icinga/ipl-html#137
requires Icinga/ipl-web#223
requires Icinga/icinga-notifications#193