ChannelForm: Render default values as element values #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviks789
force-pushed
the
channel-form-render-defaults-as-values
branch
from
9fe27b7
to
b7051ac
Compare
raviks789
force-pushed
the
channel-form-render-defaults-as-values
branch
2 times, most recently
from
c66c5b9
to
6fc00d4
Compare
nilmerg
reviewed
Apr 12, 2024
nilmerg
reviewed
Apr 12, 2024
raviks789
force-pushed
the
channel-form-render-defaults-as-values
branch
from
6fc00d4
to
4ae51ff
Compare
nilmerg
requested changes
Apr 12, 2024
raviks789
force-pushed
the
channel-form-render-defaults-as-values
branch
from
4ae51ff
to
7efdd25
Compare
nilmerg
requested changes
Apr 12, 2024
raviks789
force-pushed
the
channel-form-render-defaults-as-values
branch
from
7efdd25
to
77275e3
Compare
nilmerg
reviewed
Apr 12, 2024
raviks789
force-pushed
the
channel-form-render-defaults-as-values
branch
from
77275e3
to
bd94f9b
Compare
nilmerg
reviewed
Apr 12, 2024
There was a problem hiding this comment.
Looks fine now. But I don't like the handling of defaults for required elements: Icinga/icinga-notifications#172
raviks789
force-pushed
the
channel-form-render-defaults-as-values
branch
2 times, most recently
from
37fcc1c
to
98f4f36
Compare
nilmerg
requested changes
May 24, 2024
Instead of rendering default values as placeholders, render them as form element values.
raviks789
force-pushed
the
channel-form-render-defaults-as-values
branch
from
98f4f36
to
31de5e1
Compare
nilmerg
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of rendering default values as placeholders, render them as element values.