Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make incident age field intuitive #169

Draft
wants to merge 1 commit into
base: event-rule-config-enhancement
Choose a base branch
from
Draft

Make incident age field intuitive #169

wants to merge 1 commit into from

Conversation

raviks789
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Apr 3, 2024
@raviks789 raviks789 changed the base branch from main to event-rule-config-enhancement April 3, 2024 13:39
@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch from 3ce797e to 374a0c7 Compare April 3, 2024 13:43
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from 1d26d1c to d4e94a1 Compare April 3, 2024 13:44
@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch 7 times, most recently from 473161f to d35dd96 Compare April 11, 2024 15:28
@raviks789 raviks789 self-assigned this Apr 23, 2024
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from d4e94a1 to aab2015 Compare April 23, 2024 10:15
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch 3 times, most recently from 23933ea to 5e55ce6 Compare April 23, 2024 15:10
sukhwinder33445
sukhwinder33445 requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot save the incident age to db.

@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch 3 times, most recently from 04e9fb6 to 18bbc0a Compare April 24, 2024 11:29
@raviks789
Copy link
Contributor Author

raviks789 commented Apr 24, 2024 •
edited

Cannot save the incident age to db.

As discussed offline, this is a known issue in this PR that does not need to be fixed. As the PR #170 makes it obsolete.

@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch from 18bbc0a to 5a0ac30 Compare April 24, 2024 12:32
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch 2 times, most recently from 6c487ee to 283d33d Compare April 24, 2024 12:39
@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch 4 times, most recently from b72e697 to 37782fa Compare April 24, 2024 15:03
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from 283d33d to 645ab3e Compare April 24, 2024 15:43
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch 2 times, most recently from 81167fb to 72942bf Compare May 13, 2024 13:09
@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch from 71fcd7f to 2b31a5a Compare May 13, 2024 13:10
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from 72942bf to 0f39bb9 Compare May 13, 2024 13:12
@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch from 2b31a5a to 4bbe6f0 Compare May 13, 2024 15:24
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch 2 times, most recently from 9a51106 to 876d745 Compare May 14, 2024 12:03
@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch from 220a79d to c81fd09 Compare May 14, 2024 12:18
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from 876d745 to e12f4c6 Compare May 14, 2024 14:23
sukhwinder33445
sukhwinder33445 reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It is still possible to set 0.5m, yes we cannot save it, or when reloading it becomes 1, but it is a bug. You can simply add a default attribute value to the $valUnit element to prevent this behaviour.
  • There is extra margin.
Screenshot 2024-05-15 at 12 57 05

application/forms/EventRuleConfigForm.php Outdated Show resolved Hide resolved
application/forms/EventRuleConfigForm.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch from 6a76ace to 3dae615 Compare May 15, 2024 12:18
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch 3 times, most recently from 88ce0bd to d5c0c52 Compare May 15, 2024 13:47
@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch 3 times, most recently from 8b5bffe to be66793 Compare May 15, 2024 14:28
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from d5c0c52 to ce7d233 Compare May 15, 2024 15:44
sukhwinder33445
sukhwinder33445 requested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each autosubmit of the form resets the incident_age value.

@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from ce7d233 to 3ea2e88 Compare May 16, 2024 08:33
@raviks789
Copy link
Contributor Author

Each autosubmit of the form resets the incident_age value.

This should be fixed now.

@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from 3ea2e88 to b2c34c0 Compare May 16, 2024 08:46
sukhwinder33445
sukhwinder33445 approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch from be66793 to d31e8a6 Compare May 16, 2024 12:29
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from b2c34c0 to 0395572 Compare May 16, 2024 12:30
@raviks789 raviks789 force-pushed the event-rule-config-enhancement branch from d31e8a6 to fd35468 Compare May 21, 2024 15:52
@raviks789 raviks789 force-pushed the make-incident-age-field-intuitive branch from 0395572 to 1cbac51 Compare May 21, 2024 15:55
@nilmerg nilmerg removed this from the Beta milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukhwinder33445 sukhwinder33445 sukhwinder33445 approved these changes

Assignees

@raviks789 raviks789

Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raviks789 @sukhwinder33445 @nilmerg