Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook implementation for event object display names #165

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

raviks789
Copy link
Contributor

@raviks789 raviks789 commented Mar 21, 2024

resolves #132

Blocked by: #155, #166

requires: Icinga/ipl-web#217

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Mar 21, 2024
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch from ced4902 to 0fe4280 Compare March 21, 2024 13:53
@raviks789 raviks789 self-assigned this Mar 21, 2024
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch 5 times, most recently from 39e364e to 6081322 Compare March 25, 2024 16:43
@raviks789 raviks789 changed the title WIP: Hook implementation for event object display names Hook implementation for event object display names Mar 25, 2024
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch 2 times, most recently from 4ea63c1 to 26f9a45 Compare March 27, 2024 11:11
@nilmerg nilmerg added the enhancement New feature or improvement label Apr 9, 2024
@nilmerg nilmerg added this to the Beta milestone Apr 9, 2024
@nilmerg
Copy link
Member

nilmerg commented Apr 9, 2024

Please rebase, fix conflicts and mark as ready for review.

@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch from 26f9a45 to d9da5ee Compare April 9, 2024 14:42
@raviks789 raviks789 marked this pull request as ready for review April 9, 2024 14:42
@raviks789 raviks789 changed the base branch from main to fix/inefficient-list-views-which-render-object-names-153 April 9, 2024 14:44
@raviks789 raviks789 changed the base branch from fix/inefficient-list-views-which-render-object-names-153 to main April 9, 2024 14:45
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch 8 times, most recently from a41ed3d to 70fc00e Compare April 22, 2024 13:17
@sukhwinder33445 sukhwinder33445 self-requested a review May 17, 2024 07:18
@sukhwinder33445
Copy link
Contributor

Please rebase and resolve the conflicts.

@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch from 70fc00e to 59dd1e6 Compare May 17, 2024 09:58
library/Notifications/Hook/EventsObjectsInfoHook.php Outdated Show resolved Hide resolved
library/Notifications/Hook/EventsObjectsInfoHook.php Outdated Show resolved Hide resolved
library/Notifications/Hook/EventsObjectsInfoHook.php Outdated Show resolved Hide resolved
library/Notifications/Hook/EventsObjectsInfoHook.php Outdated Show resolved Hide resolved
library/Notifications/Widget/Detail/EventDetail.php Outdated Show resolved Hide resolved
library/Notifications/Widget/ItemList/EventList.php Outdated Show resolved Hide resolved
library/Notifications/Widget/ItemList/EventList.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch 2 times, most recently from 2d1a99b to 2c9d5c3 Compare May 17, 2024 12:54
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch 2 times, most recently from 3ddb0d0 to 62990e7 Compare May 17, 2024 13:46
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch 6 times, most recently from bce9c46 to aec48d1 Compare May 23, 2024 11:13
library/Notifications/Hook/EventsObjectsInfoHook.php Outdated Show resolved Hide resolved
library/Notifications/Widget/ItemList/EventList.php Outdated Show resolved Hide resolved
library/Notifications/Hook/ObjectsRendererHook.php Outdated Show resolved Hide resolved
library/Notifications/Hook/ObjectsRendererHook.php Outdated Show resolved Hide resolved
library/Notifications/Hook/ObjectsRendererHook.php Outdated Show resolved Hide resolved
library/Notifications/Hook/ObjectsRendererHook.php Outdated Show resolved Hide resolved
library/Notifications/Hook/ObjectsRendererHook.php Outdated Show resolved Hide resolved
library/Notifications/Widget/ItemList/EventListItem.php Outdated Show resolved Hide resolved
@Icinga Icinga deleted a comment from sukhwinder33445 May 24, 2024
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch 3 times, most recently from 989d8f5 to fd0ffe7 Compare May 24, 2024 11:06
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch 3 times, most recently from 5c933c2 to 27e25b6 Compare May 24, 2024 12:45
@raviks789 raviks789 force-pushed the feature/event-object-hook-implementation branch from 893f852 to b30580e Compare May 24, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement hooks to render objects
3 participants