Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Icinga states to pod #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Icinga states to pod #72

wants to merge 1 commit into from

Conversation

jhoxhaa
Copy link
Collaborator

@jhoxhaa jhoxhaa commented Apr 25, 2024

No description provided.

@jhoxhaa jhoxhaa self-assigned this Apr 25, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Apr 25, 2024
@jhoxhaa jhoxhaa requested a review from lippserd April 25, 2024 08:35
@jhoxhaa jhoxhaa force-pushed the add-icinga-states-to-pod branch 3 times, most recently from 8923ef0 to 08e77ee Compare May 10, 2024 10:54
@jhoxhaa jhoxhaa force-pushed the add-icinga-states-to-pod branch 2 times, most recently from 773bbe5 to f34a587 Compare May 17, 2024 09:57
lippserd
lippserd requested changes May 22, 2024
View reviewed changes
Copy link
Member

@lippserd lippserd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be also good to add some text which explains the state, e.g.

Init container $name terminated with non-zero exit code $code: $reason

You could add icinga_state_reason text for that.

@jhoxhaa jhoxhaa requested a review from lippserd May 23, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd Awaiting requested review from lippserd

Assignees

@jhoxhaa jhoxhaa

Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhoxhaa @lippserd