Add F-beta score #86
Open
Add F-beta score #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proccaserra
reviewed
May 20, 2022
There was a problem hiding this comment.
@shawntanzk a quick comment as I saw F-beta score is asserted under F-statistic. I figured out this is not ideal as the F-beta score does not follow an F-distribution and would be a subtype.
It'd be better suited as a child of 'score' and we could define it with respect to other types. I'll try something soon.
thx again!
Thanks for figuring this out :) honestly would have never known. child of 'score' sounds good! I'm guessing you have some other ideas so I'll leave the fix to you then. Thanks so much once again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85
Hi @proccaserra thought I'd try to edit the ontology.
I've only edited ODK based GO-style ontologies, so not 100% sure I did everything right here.
We are also unsure on how to use this (a class) to annotate axioms - was wondering if you had any experience with this.
also tagging @hkir-dev @dosumis
Thanks