Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking to data file type column names 2. #553

Open
wants to merge 8 commits into
base: issue-511
Choose a base branch
from

Commits on Mar 16, 2024

  1. Configuration menu
    Copy the full SHA
    2cb095b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Added new test

    Testing that the changes fix what was raised in ISA-tools#509.
    ptth222 committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    ca12fe4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Name headers also tracked

    Changed the added test to be more realistic. Had to track name columns like Data Transformation Name so values would be handled correctly.
    ptth222 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    e50e65e View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Addressed comments in ISA-tools#553

    Removed code using ' File' to find data nodes. Added comments and broke up code to be more readable and understood.
    ptth222 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    bc33a2f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    ed25daa View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Changed write based on comments in ISA-tools#553

    test_core had to change because the config file in the test data changed.
    ptth222 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    ad22cae View commit details
    Browse the repository at this point in the history
  2. Changes to make tests work

    validate/test_core mtbls1846 lost all of the errors for middle initial being required, but is no longer required. Added validate_first=False to some conversion tests so they run faster. assert_tab_content_equal in utils.py was not checking things correctly. Lists of dataframes cannot be sorted without defining a "key" parameter. I simply removed the sorting and added returning False on an error rather than True.
    ptth222 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4a8b735 View commit details
    Browse the repository at this point in the history
  3. Removed commented out code

    ptth222 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    770db3c View commit details
    Browse the repository at this point in the history