-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracking to data file type column names 2. #553
Open
ptth222
wants to merge
8
commits into
ISA-tools:issue-511
Choose a base branch
from
ptth222:fix-data-file-name-bug2
base: issue-511
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Mar 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2cb095b - Browse repository at this point
Copy the full SHA 2cb095bView commit details
Commits on Mar 17, 2024
-
Testing that the changes fix what was raised in ISA-tools#509.
Configuration menu - View commit details
-
Copy full SHA for ca12fe4 - Browse repository at this point
Copy the full SHA ca12fe4View commit details
Commits on Mar 21, 2024
-
Changed the added test to be more realistic. Had to track name columns like Data Transformation Name so values would be handled correctly.
Configuration menu - View commit details
-
Copy full SHA for e50e65e - Browse repository at this point
Copy the full SHA e50e65eView commit details
Commits on May 20, 2024
-
Addressed comments in ISA-tools#553
Removed code using ' File' to find data nodes. Added comments and broke up code to be more readable and understood.
Configuration menu - View commit details
-
Copy full SHA for bc33a2f - Browse repository at this point
Copy the full SHA bc33a2fView commit details
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ed25daa - Browse repository at this point
Copy the full SHA ed25daaView commit details
Commits on Jun 3, 2024
-
Changed write based on comments in ISA-tools#553
test_core had to change because the config file in the test data changed.
Configuration menu - View commit details
-
Copy full SHA for ad22cae - Browse repository at this point
Copy the full SHA ad22caeView commit details -
validate/test_core mtbls1846 lost all of the errors for middle initial being required, but is no longer required. Added validate_first=False to some conversion tests so they run faster. assert_tab_content_equal in utils.py was not checking things correctly. Lists of dataframes cannot be sorted without defining a "key" parameter. I simply removed the sorting and added returning False on an error rather than True.
Configuration menu - View commit details
-
Copy full SHA for 4a8b735 - Browse repository at this point
Copy the full SHA 4a8b735View commit details -
Configuration menu - View commit details
-
Copy full SHA for 770db3c - Browse repository at this point
Copy the full SHA 770db3cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.