Add tracking to data file type column names. #510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix issue ISA-tools#509.
The label in the DataFile object was carrying through the ".1", ".2", etc. added to the end by pandas. Changed it so the label is pulled out of the column name.
|
I have made changes based on what was said in issue #509. It was more difficult than I thought, and I couldn't keep the graph implementation, but please take a look and see if this is a better solution. I tested on a few different edge cases and seems to produce what I was intending. |
|
@ptth222 we're still looking at this as there are ramifications in the isatab component. |
|
Thank you for the update. This is a pretty significant change, so I expected it to take a while to analyze. |
|
This was replaced with #553. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issue #509.