[FEATURE] UI: centralise ComponentRenderer::render()
#7469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstanceof checks.
thibsy
force-pushed
the
feature/10/ui-central-render-function
branch
from
2b50431
to
bf5d501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
This is one part of the PR I created to introduce JavaScript hydration to the UI framework (#6948).
It centralises the
ComponentRenderer::render()function inside ourAbstractComponentRendererby using a new abstract method calledrenderComponent()and gets rid of theAbstractComponentRenderer::checkComponent()calls. I also tried to streamline theinstanceofchecks a bit, and returned null in methods which threw aLogicExceptionor returned an empty string if the component could not be handled.Also note that I changed the exception from a
LogicExceptionto aRuntimeException, because at this point errors will only ever be discovered at runtime.Kind regards,
@thibsy