Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add Info When No Items In Drilldown #7462

Conversation

kergomard
Copy link
Contributor

Hi everybody
@oliversamoila noticed that we are currently not showing any information in a Drilldown that is empty, so I changed that.

If this PR is merged, if you filter everything from a Drilldown you will see:
grafik

Thanks and best,
@kergomard

@Amstutz
Copy link
Contributor

Amstutz commented May 15, 2024

Hi @kergomard

Thx a lot for tackling this!

First a non-actionable note, I personally do not like property promotion. However, they are already in use and my colleagues do not mind. So I won't either.

Change or shortly explain why not:

  • No Item Text: You put the no item text directly on the components object. I would regard this rather as just a rendering detail, and would therefore rather opt to just pack it directly into the rendering. This has the additional advantage, that the lng dep. is already available there.

Thx a lot
@Amstutz in consultation with @klees and @thibsy

@kergomard
Copy link
Contributor Author

Hi @Amstutz , hi all
Thank you very much for the review.
You are completely right: I moved text to the renderer.
I also removed the property promotion as I don't need to touch this class anymore. Personally I'm a big fan, as I think that it improves readability hugely and it reduces the potential for errors.

Thanks again and best,
@kergomard

@Amstutz
Copy link
Contributor

Amstutz commented May 29, 2024

Thx a lot!

@Amstutz Amstutz merged commit 98436c6 into ILIAS-eLearning:trunk May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants