-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix M_PI_2 migration which was breaking transitions #441
Conversation
After a few testing for #305, it seems to fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, must be me introduced those bugs. All good, thanks for fixing them 👍👍👍
@@ -173,7 +173,7 @@ private extension FlipAnimator { | |||
completion: @escaping AnimatableCompletion) { | |||
UIView.animateKeyframes(withDuration: transitionDuration, delay: 0, options: .layoutSubviews, animations: { | |||
UIView.addKeyframe(withRelativeStartTime: 0.0, relativeDuration: 0.5, animations: { | |||
flippedSectionOfFromView.0.layer.transform = self.rotate(angle: self.reverse ? -.pi * 2 : .pi * 2) | |||
flippedSectionOfFromView.0.layer.transform = self.rotate(angle: (self.reverse ? -.pi : .pi) / 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the self
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we do but #446 removes all of them where not necessary. I could've missed some but I think I got them all 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SD10 thanks for taking care of self
.
@tbaranes I merged the PR now. I think we saw this issue before when we have a navigation bar, I looked at it before and didn't find a solution for fixing it. |
Close #440
Fix a few animators, introduced in 10104cd:
Thanks to @phimage for the fix!
@SD10 This fix the broken transition you reported a few days ago
May also close #305 ? Need more testing to confirm