Fix M_PI_2 migration which was breaking transitions #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After a few testing for #305, it seems to fix |
JakeLin
approved these changes
Apr 11, 2017
| @@ -173,7 +173,7 @@ private extension FlipAnimator { | |||
| completion: @escaping AnimatableCompletion) { | |||
| UIView.animateKeyframes(withDuration: transitionDuration, delay: 0, options: .layoutSubviews, animations: { | |||
| UIView.addKeyframe(withRelativeStartTime: 0.0, relativeDuration: 0.5, animations: { | |||
| flippedSectionOfFromView.0.layer.transform = self.rotate(angle: self.reverse ? -.pi * 2 : .pi * 2) | |||
| flippedSectionOfFromView.0.layer.transform = self.rotate(angle: (self.reverse ? -.pi : .pi) / 2) | |||
@tbaranes I merged the PR now. I think we saw this issue before when we have a navigation bar, I looked at it before and didn't find a solution for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #440
Fix a few animators, introduced in 10104cd:
Thanks to @phimage for the fix!
@SD10 This fix the broken transition you reported a few days ago
May also close #305 ? Need more testing to confirm