Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

WIP: fix(patients): allow the duplicate patient modal to show properly on … #2785

Open
wants to merge 84 commits into
base: master
Choose a base branch
from

Conversation

connordmccandless
Copy link

@connordmccandless connordmccandless commented Oct 20, 2021

…possible duplicate patient

fix #2546

Changes proposed in this pull request:

  • duplicatePatientList in DuplicateNewPatientModal.tsx properly updated to an array of patients as opposed to a single patient
  • NewPatient.tsx now uses the usePatients hook instead of the state (that isn't being updated) to properly retrieve the current list of all patients

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2021

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Oct 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/B9YQf3jgFbhbE7RLwvdP53ALr9uQ
✅ Preview: https://hospitalrun-frontend-git-fork-connordmccandl-ebb413-hospitalrun.vercel.app

@matteovivona matteovivona marked this pull request as ready for review October 21, 2021 13:33
@matteovivona matteovivona requested review from a team, jackcmeyer, DrewGregory and anthonyaperez and removed request for a team October 21, 2021 13:33
@matteovivona
Copy link
Contributor

@connordmccandless is still in wip?

@connordmccandless
Copy link
Author

@tehkapa I left a comment on the ticket when I last worked on the issue. I fixed the issue described in the ticket, but it seems that the written tests are not written correctly and will always return a failure. I wasn't sure if rewriting the test code would be part of the ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Patient Modal cannot be triggered
4 participants