This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
jack: remove dead celt dep #37146
Closed
jack: remove dead celt dep #37146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Celt in 45f47a5e73ab8f506231c30e42a7 53a0cb841832 which upset Jack. I ran a `brew uses` beforehand but apparently missed the one-formula reply because I was particularly stupid at the time. It builds and works fine without it. Celt at best should have been a recommended or optional dep, I suspect. Opus has indeed replaced Celt, but because they merged it into Opus and ditched the Celt name, Jack doesn’t know how to find it under the new name. Either upstream hasn’t done anything about the change, or it hasn’t been reported, I guess. Closes #37134
|
This should get merged, because until that dep is removed, instead of just saying "celt". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Celt in 45f47a5 which upset Jack. I ran a
brew usesbeforehand but apparently missed the one-formula reply because I was particularly stupid at the time.It builds and works fine without it. Celt at best should have been a recommended or optional dep, I suspect. Opus has indeed replaced Celt, but because they merged it into Opus and ditched the Celt name, Jack doesn’t know how to find it under the new name. Either upstream hasn’t done anything about the change, or it hasn’t been reported, I guess.
Filed a bug report incase: jackaudio/jack1#19
Closes #37134