Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sniffnet 1.1.3 #127533

Closed
wants to merge 1 commit into from
Closed

sniffnet 1.1.3 #127533

wants to merge 1 commit into from

Conversation

p-linnane
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

release notes 
### New features

    

  • Added feature to warn you when a newer version of Sniffnet is available on GitHub 馃啎 (#118)
    • 

  • Added badge on tab bar to show unread notifications count 馃攭
    • 

  • Added Romanian translation 馃嚪馃嚧 (#113)
    • 



Improvements


    

  • Introduction of lazy widgets to improve the application efficiency (#122)
    • 

  • Aesthetic improvements to create a more modern and minimal UI (use #119 to suggest me further improvements)
    • 

  • Changed keyboard shortcut to open settings from ctrl+S to ctrl+,, as suggested in #97
    • 

  • Refactored and cleaned code modules (#123)
    • 



Fixes


    

  • Fixed problem that was causing a switch to the initial page when back button was pressed with settings opened on running page and with no packets received
    • 

  • Fixed problem that was causing application logo to be partially hidden when resizing the window to a lower dimension
    • 

  • Show - option in app protocol picklist only when a filter is active
    • 

  • Fixed header alignment
    • 



Thanks to:


    

  • @ervinpopescu for Romanian translation (#113)
    • 

  • @0x0177b11f for being my first sponsor ever 鉂わ笍

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Apr 4, 2023
chenrui333
chenrui333 reviewed Apr 4, 2023
View reviewed changes
Formula/sniffnet.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Apr 4, 2023
@p-linnane
Copy link
Member Author

Do we want to scope those additional changes just to Linux? Or move the openssl@1.1 dep out of the on_linux do block?

@GyulyVGC
Copy link

GyulyVGC commented Apr 4, 2023 •
edited

I'm the maintainer of Sniffnet.
I don't know if this is the best place to ask, but version 1.1.2 installed via Hombrew had some problems (see this issue).
What could the cause be? It seems like the package was built unsuccessfully. I was wondering if the problem will be solved with this new release.
Thanks in advance!

@chenrui333

This comment was marked as off-topic.

Sign in to view
@chenrui333
Copy link
Member

I can reproduce the same issue in my local

thread 'main' panicked at '', /Users/rui/Library/Caches/Homebrew/cargo_cache/registry/src/github.com-1ecc6299db9ec823/wgpu-hal-0.14.1/src/metal/adapter.rs:485:13
stack backtrace:
   0:        0x1004888a0 - __mh_execute_header

@p-linnane @chenrui333
sniffnet 1.1.3
046fdea 
sniffnet: add openssl@3

Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Apr 5, 2023
@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Apr 5, 2023
@p-linnane p-linnane added the upstream issue An upstream issue report is needed label Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Apr 9, 2023
@github-actions github-actions bot closed this Apr 10, 2023
@p-linnane p-linnane deleted the bump-sniffnet-1.1.3 branch April 10, 2023 15:10
@chenrui333
Copy link
Member

#128787

@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` rust Rust use is a significant feature of the PR or issue stale No recent activity superseded PR was replaced by another PR test failure CI fails while running the test-do block upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@p-linnane @GyulyVGC @chenrui333