Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1password7 remove conflicts #172465

Merged

Conversation

jabenninghoff
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This PR removes conflicts that were recently added in #172356. 1Password7 doesn't conflict with the current version of 1Password (version 8) - I have been running both side-by-side with no issues for some time. Additionally, there is a good use case for installing both, as 1Password7 is the last version of 1Password that supports local vaults, and was useful in migration. I'd appreciate it if this PR can be accepted to allow installing both versions.

@razvanazamfirei
Copy link
Member

Thank you, @jabenninghoff!

@razvanazamfirei razvanazamfirei merged commit bb17b7b into Homebrew:master Apr 29, 2024
17 checks passed
@jabenninghoff jabenninghoff deleted the 1password7-remove-conflicts branch April 29, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants