Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pecunia 2.1.7 (new cask) #172273

Merged
merged 2 commits into from Apr 29, 2024
Merged

pecunia 2.1.7 (new cask) #172273

merged 2 commits into from Apr 29, 2024

Conversation

clashman
Copy link
Contributor

@clashman clashman commented Apr 26, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added new cask missing zap Cask is missing a zap stanza, please add one. labels Apr 26, 2024
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Apr 27, 2024
@krehel
Copy link
Member

krehel commented Apr 27, 2024

@reitermarkus - do you mind providing an opinion here? This seems like a very specific software, e.g. is it only useful for the German market?

@krehel krehel added the awaiting maintainer feedback Issue needs response from a maintainer. label Apr 27, 2024
@reitermarkus
Copy link
Member

HBCI seems to be a German thing, but it seems to support PSD2, which is an EU thing, since version 2.0.

Casks/p/pecunia.rb Outdated Show resolved Hide resolved
@clashman
Copy link
Contributor Author

@reitermarkus - do you mind providing an opinion here? This seems like a very specific software, e.g. is it only useful for the German market?

HBCI seems to be a German thing, but it seems to support PSD2, which is an EU thing, since version 2.0.

Why is any of this important for inclusion into the repo?

@bevanjkay
Copy link
Member

Casks that are included here (homebrew-cask) should meet a certain level of notability/demand. If they are only used by a couple of individuals, then they are best hosted in a personal tap. The questions are to ascertain the popularity/notability of the application.

Co-authored-by: Bevan Kay <bevanjkay@gmail.com>
@p-linnane p-linnane removed the awaiting maintainer feedback Issue needs response from a maintainer. label Apr 29, 2024
@chenrui333 chenrui333 changed the title pecunia 2.1.7 pecunia 2.1.7 (new cask) Apr 29, 2024
@miccal miccal merged commit 08d7067 into Homebrew:master Apr 29, 2024
12 checks passed
@miccal
Copy link
Member

miccal commented Apr 29, 2024

Thank you @clashman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants