Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appium 1.22.0 #112217

Merged
merged 2 commits into from Oct 6, 2021
Merged

appium 1.22.0 #112217

merged 2 commits into from Oct 6, 2021

Conversation

miccal
Copy link
Member

@miccal miccal commented Oct 6, 2021

Token reference?

Casks/appium.rb Outdated Show resolved Hide resolved
Co-authored-by: George Adams <georgeadams1995@gmail.com>
@gdams
Copy link
Contributor

gdams commented Oct 6, 2021

Trying to understand what the difference is between this cask and https://github.com/Homebrew/homebrew-core/blob/master/Formula/appium.rb? Is this cask Appium Desktop? In which case it should likely be renamed to appium-desktop to avoid confusion

@SMillerDev
Copy link
Member

Appium desktop is really just a GUI for Appium, which is the formula. I don't think it needs to be renamed.

@gdams gdams merged commit c43ed71 into master Oct 6, 2021
@gdams gdams deleted the miccal-appium branch October 6, 2021 08:51
@miccal
Copy link
Member Author

miccal commented Oct 6, 2021

Trying to understand what the difference is between this cask and https://github.com/Homebrew/homebrew-core/blob/master/Formula/appium.rb? Is this cask Appium Desktop? In which case it should likely be renamed to appium-desktop to avoid confusion

We drop desktop as per the token reference.

Following the token reference strictly, this should be re-named to appium-server-gui.

Ping @vitorgalvao.

@gdams
Copy link
Contributor

gdams commented Oct 6, 2021

Following the token reference strictly, this should be re-named to appium-server-gui.

My interpretation of the token reference is that we should also remove -gui to it should just be appium-server?

@vitorgalvao
Copy link
Member

My interpretation of the token reference is that we should also remove -gui.

The token reference is mostly comprehensive and gui isn’t singled out.

We remove “Desktop” and “Mac” because those are overused, redundant (every cask is for macOS and Desktop), and impair searchability.

appium-server-gui is the strictly correct name.

@miccal
Copy link
Member Author

miccal commented Oct 6, 2021

@vitorgalvao I was a little hesitant on a rename:

==> Analytics
install: 151 (30 days), 409 (90 days), 1,268 (365 days)

@vitorgalvao
Copy link
Member

I was a little hesitant on a rename

@gdams is considering looking into cask renames, so let’s hold on the rename. If we can do it later with little inconvenience to hundreds of users, so much the better.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants